[5.x] Ensure query parameters are retained in pagination links #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
changed the title
duncanmcclean
deleted the
fix/ensure-query-parameters-are-retained-in-pagination
branch
duncanmcclean
restored the
fix/ensure-query-parameters-are-retained-in-pagination
branch
duncanmcclean
deleted the
fix/ensure-query-parameters-are-retained-in-pagination
branch
|
Released as part of v5.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue that #350 previously tried to fix, where query parameters weren't being retained in the pagination links.
I just needed to move the
->withQueryString()method to the other paginator which seemed to do the trick.Closes #349.